dependency update (& remove happy_with) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxg558
commented
Nov 1, 2024
| @@ -36,14 +36,13 @@ defmodule Avrogen.MixProject do | |||
| defp deps do | |||
| [ | |||
| {:accessible, "~> 0.3"}, | |||
| {:credo, "~> 1.7", only: [:dev, :test], runtime: false}, | |||
| {:credo, "== 1.7.1", only: [:dev, :test], runtime: false}, | |||
There was a problem hiding this comment.
This was to avoid a big refactor to deal with:
┃ [R] ↗ Predicate function names should not start with 'is', and should end in a
┃ question mark.
┃ lib/avrogen/types.ex:50:7 #(Avrogen.Types.is_primitive?)
We can do it one day, but not now
| @@ -16,8 +16,8 @@ jobs: | |||
| steps: | |||
| - uses: erlef/setup-beam@v1 | |||
| with: | |||
| elixir-version: 1.15 | |||
There was a problem hiding this comment.
What about using a matrix to test latest and older versions?
There was a problem hiding this comment.
if you know how to do it, that could be worthwhile in future
cottinisimone
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
happy_withlibrary -- there were no usages that couldn't have been acaseor a regularwith, and the library triggers compile warnings on OTP26+: